Dimillian / Dimillian/IceCubesApp
Feature request: pop-up player is much smaller than the timeline preview on iPads
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 7.1k
- Forks
- 720
- PR merge metrics
- No merged PRs in 30d
Description
- On an iPad, scroll to a post with a video.
- Tap on it to play.
Expected: inline playback, or full-screen playback
Actual: a portrait-orientation pop-over containing a much smaller video than in the preview, which is ridiculous. See screenshot and note that the preview area is actually ample:
There is a button in the sheet's navbar to invoke a full-screen player from there, but it's misleadingly labeled as ⓘ which generally means "info".
I think what happened is that an iPhone-ism wasn't disabled on iPads. Tapping on the video in the timeline view should either play inline or invoke the full-screen player, not this intermediate sheet that serves no purpose on iPads.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the timeline video tap on iPad and the code that presents the portrait pop-over player. Inspect the sheet's navbar button and its ⓘ label. Done means tapping a timeline video uses inline or full-screen playback on iPads without the intermediate sheet, with the control label matching its action.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100