Dimillian / Dimillian/IceCubesApp

Bug: Dismissing Context Menu will trigger click on underlying elements

Open
#1,543 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Swift
Stars
7.1k
Forks
720
PR merge metrics
No merged PRs in 30d

Description

Environment:

  • OS: iOS 16.6
  • IceCubesApp version: 1.7.3

Description

The context menu (which can be triggered by tapping the "three dots" icon in the top right corner of every toot) can be closed/dismissed by tapping anywhere outside of the menu. However this "closing tap" will still be registered as a normal tap. So whatever you tap on, will still be the tap target. Instead, the tap outside of the menu should only close the menu.

Related Issues

This is especially annyoing due to #1528, where this context menu is triggered a lot by accident.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on iOS 16.6 with IceCubesApp 1.7.3: open a toot's context menu and tap outside it. Trace the context-menu dismissal behavior and verify that the outside tap closes only the menu without activating the underlying element.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.