DiamondLightSource / DiamondLightSource/sm-bluesky
Create mock logic for apple2 insertion device
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 2d 3m
- Merged PRs (30d)
- 8
Description
The insertion devices for apple2 insertion devices need to have mock logic added so that we can use the devices in mock mode and also create better test coverage e.g simulate whenever `set_move` is called for `phase` and `gap`, the gate will open and then close. See comment https://github.com/DiamondLightSource/dodal/pull/2161#discussion_r3795467038
Contributor guide
Research direction
Start by locating the Apple2 insertion device implementations and their existing mock-mode support, then review the linked discussion about the expected behavior. Trace set_move for phase and gap; done means mock moves simulate the gate opening and closing and the behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100