DiamondLightSource / DiamondLightSource/psc-datalogger

Rationalize data validation into a single location

Open
#12 0 comments 0 reactions 1 assignee Claimed by @AlexanderWells-diamond View on GitHub
Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Currently there is data validation happening at multiple layers. For example the function `DataloggerMainWindow.handle_instrument_changed()` currently passes the raw data from the GUI widgets down into lower layers, and then there are multiple conversions and checks done at various levels. All of these checks can probably be hoisted into the GUI layer, which can populate a (new?) data structure containing the relevant information to pass to the backend for processing.

This was noted as part of the review of PR #11.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.