DiamondLightSource / DiamondLightSource/pmac
Change Turbo VersionNum to be 5 to match Power and investigate odd error message
- Dominant language
- C++
- Stars
- 31
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
The Power motion program was updated to have version number 5, as was the driver, but the Turbo is still on version 4. This line needs to read 5:
https://github.com/DiamondLightSource/pmac/blob/02c4f7247c760634e73b4e5175e3380844c3a77a/pmacApp/pmc/trajectory_scan_definitions.pmc#L10
This ticket should also improve the error message when version numbers don't match. At the moment you can `build` fine, but when you `execute` you get this error:
https://github.com/DiamondLightSource/pmac/blob/02c4f7247c760634e73b4e5175e3380844c3a77a/pmacApp/src/pmacController.cpp#L3333-L3334
Instead it should give an error that version numbers don't match.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.