DiamondLightSource / DiamondLightSource/pmac

PowerPMAC Coordinate System Status not supported

Open
#152 0 comments 0 reactions 0 assignees View on GitHub
bug ppmac
Dominant language
C++
Stars
31
Forks
25
PR merge metrics
No merged PRs in 30d

Description

The bits definitions for the two bytes words containing the status of the Coordinate Systems in the `pmacCsController.cpp ` support only the TurboPMAC controllers - link to the snippet belllow:

https://github.com/DiamondLightSource/pmac/blob/dfc9726adc33f89a2bbf9d2bc9d07fa2e67119c1/pmacApp/src/pmacCSController.h#L141C1-L191C73

That might cause :
- False errors - the bits has different uses,
- Undetected statuses - with the PowerPMAC having 32 bits in each word, while the TurboPMAC has only 24.

As suggestion for fixing, the same approached of the [PR #114](https://github.com/DiamondLightSource/pmac/pull/114)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.