DiamondLightSource / DiamondLightSource/nexgen

Do not write unused VDS files in the first place

Open
#87 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2
Forks
9
PR merge metrics
No merged PRs in 30d

Description

When, in artemis, we have a large grid, there are more than two datasets linked in the nexus files, and for the second nexus file, the first dataset may not be used. In that case,

https://github.com/DiamondLightSource/python-dlstbx/blob/main/src/dlstbx/swmr/h5check.py

fails when running

```python
plist = dataset.id.get_create_plist()
...
vspace = plist.get_virtual_vspace(0)
frames = vspace.get_regular_hyperslab()[3][0]
```

because that dataset has no corresponding slab of the vds.

I would like it if completely unused datasets are not linked in the nexus file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.