DiamondLightSource / DiamondLightSource/mx-bluesky

Handle XRC snapshots outside of grid detect plan

Open
#926 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

Our ispyb callback for XRC assumes that the snapshots have been taken during the grid detect plan. For VMXm, there is no grid detect - we'd like snapshots to be taken independently using the `oav_snapshot_plan`

We need to adjust the XRC ispyb_callback so that it can also handle the event where the `oav_snapshot_plan` has been ran. This will probably look very similar to `activity_gated_event` in `rotation/ispyb_callback`

## Acceptance Criteria
- XRC ispyb callbacks listen for the `oav_snapshot_plan` and deposit these snapshots to ispyb
- This callback knows whether it needs to listen for the `oav_snapshot_plan` OR the snapshots in `grid_detection_plan`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.