DiamondLightSource / DiamondLightSource/mx-bluesky

Create integration test for ISPyB group comments

Open
#915 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

In https://github.com/DiamondLightSource/mx-bluesky/pull/832, we added logic to construct and update the ispyb group comment based on the following assumptions on the ordering of events:

If we are using grid detect:
1. FGS ispyb start document received
2. Two OAV snapshot events gives the first part of the group comment
3. Zocalo is triggered and the event from this adds the last part of the comment
4. Stop document clears the group comment field

If we are using grid detect, same as the above but we skip step 2, so the group comment doesn't contain any info about the grid sizes.

We should add integration tests for these which will error if the above assumptions are ever broken. Don't start this until https://github.com/DiamondLightSource/mx-bluesky/pull/828 is done

## Acceptance Criteria
- Make test which uses the `RunEngine` with the proper callbacks, which goes from grid detect to XRC, and makes sure the comment looks correct.
- Same thing but XRC without grid detect

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.