DiamondLightSource / DiamondLightSource/mx-bluesky
Discuss: Use of the xbpm pause feedback preprocessor
- Dominant language
- Python
- Stars
- 4
- Forks
- 5
- Avg merge
- 1d 30m
- Merged PRs (30d)
- 2
Description
Following https://github.com/DiamondLightSource/mx-bluesky/pull/872 the xbpm pausing is a preprocessor. This is cleaner as it allows us to optionally use it on different beamlines but use the same underlying plan. However, currently it only injects itself in `run_open` and then only on one specific run name. Ideally I should be able to use it more broadly e.g.
```python
def i03_udc():
pause_xbpm_during_collections_or_energy_changes_wrapper(generic_udc)
```
This is complicated by the number of different runs we open. Under it's current implementation it also means that `set_energy` needs to be a run, which is a bit odd so maybe we should inject when we see the energy set in any way.
## Acceptance Criteria
- Discuss how we do the above
- Decision is documented
Contributor guide
Assessment
This issue has not been assessed yet.