DiamondLightSource / DiamondLightSource/mx-bluesky

Import linter doesn't catch everything

Open
#696 0 comments 0 reactions 0 assignees View on GitHub
dev experience good first issue
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

In https://github.com/DiamondLightSource/mx-bluesky/pull/652, I had imported some `hyperion` files into `mx_bluesky.common` and the linting still passed. We should make sure the import linter catches this.

Specifically, it was in `mx_bluesky.common.parameters.gridscan.py`:
`from mx_bluesky.hyperion.parameters.constants import CONST`

## Acceptance Criteria
- Extra rules for the import-linter in CI

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.