DiamondLightSource / DiamondLightSource/mx-bluesky

Race condition between `update_barcode_and_snapshots` and oav snapshot last saved path

Open
#690 1 comment 0 reactions 0 assignees View on GitHub
bug hyperion
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

`test_load_centre_collect_full_plan` has a line
```
robot_load_cb.expeye.update_barcode_and_snapshots.assert_called_once_with(
1234,
"BARCODE",
"/tmp/dls/i03/data/2024/cm31105-4/auto/123457/xraycentring/snapshots/160705_webcam_after_load.png",
"/tmp/snapshot1.png",
)
```
(currently commented out)
which fails with `after_snapshot` being empty due to the callback being invoked before `MJPG._save_image` updates the `last_saved_path` when doing the post-processing for the OAV snapshot

## Acceptance Criteria
- Test passes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.