DiamondLightSource / DiamondLightSource/mx-bluesky

Reinstate full mapping (and fix all the functions that are needed there)

Open
#648 0 comments 0 reactions 0 assignees View on GitHub
I24 serial
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

Removed in #515

We will need to sit down with the beamline scientists to understand what was needed of the removed code, what was broken and how exactly it should work.

Some notes to be able to find things in older versions ...

Motion program: 13
get_prog_num: 13

In write_parameter_file for chip:
```python
if map_type == MappingType.Full:
# This step creates some header files (.addr, .spec), containing the parameters,
# that are only needed when full mapping is in use.
SSX_LOGGER.info("Full mapping in use. Running start up now.")
startup.run()
```

`i24ssx_Chip_Mapping_py3v1.py` completely removed

startup.run()
- check_files (also used in mapping file)
- write_headers

also in chip startup:
- get_shot_order
- get_xy
- write_file

in chip_manager:
- load full map
- upload_full

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.