DiamondLightSource / DiamondLightSource/mx-bluesky

I24 SSX: Create a data collection group on start

Open
#576 1 comment 0 reactions 0 assignees View on GitHub
I24 serial
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

When the serial plan starts we want to make a data collection group with the correct parameters. We can do this by doing something similar to what `GridscanISPyBCallback` does on `activity_gated_start`.

- [ ] Make the serial collection plan emit a start document at the beginning of running
- [ ] Move `DiffractionExperimentWithSample` to somewhere common and make one in the plan out of the parameters we have
- [ ] The start document should have enough info to be able to call `populate_data_collection_group` by putting the params into something that inherits from `DiffractionExperimentWithSample`
- [ ] Move `BaseISPyBCallback` into the common area
- [ ] Create a subclass of `BaseISPyBCallback` that uses these parameters to make a group at start (does it make sense to refactor this into the start of `BaseISPyBCallback`?)

## Acceptance Criteria
- On running serial collections a group is created with the expected params
- There is a system test that runs this against the dev ispyb database (we already have similar for other plans)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.