DiamondLightSource / DiamondLightSource/mx-bluesky

Multi-rotation and multipin plans don't support certain combinations that are implied by the parameter model

Open
#563 2 comments 0 reactions 1 assignee Claimed by @rtuck99 View on GitHub
hyperion
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

Currently the plans only support a fixed number of frames per rotation, whereas the `MultiRotationScan` `RotationScanPerSweep` allows variable rotation width which implies variable frames if you have fixed exposure per frame. Also there's a fixed `omega_start` in the `DetectorParams` which we currently assume to be the same as the first.

We should limit the flexibility allowed by the model if we decide not to implement this functionality, or at least validate that these constraints are maintained.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.