DiamondLightSource / DiamondLightSource/mx-bluesky
Add character limit and allowed character checks to detector device
Open
enhancement
- Dominant language
- Python
- Stars
- 4
- Forks
- 5
- Avg merge
- 1d 30m
- Merged PRs (30d)
- 2
Description
Detectors have limits on the number of characters that can be used in sample prefixes. The ispyb limit is 45.
Pilatus is 23
Eiger is 100
We should keep this in mind with detector devices and ensure that invalid file prefixes are caught and handled cleanly.
Currently a mix of truncation and character stripping is applied by GDA and Agamemnon, but it isn't pretty. This is technical debt we should not carry forward.
Contributor guide
Assessment
This issue has not been assessed yet.