DiamondLightSource / DiamondLightSource/mx-bluesky

Bit depth being written wrong due to dectris firmware changes

Open
#374 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

Data files are being written with 32 bit depth even when data collected at 16 bit depth, this is causing zocalo issues with wrong max pixel values. The "correct" bit depth is now included in the meta file in `_dectris/bit_depth_image`

currently patched live on beamline in `write_nexus.py` line 176 where we do

```python
"bit_depth_readout": "_dectris/bit_depth_image",
```
instead of previously
```python
"bit_depth_readout": "_dectris/bit_depth_readout",
```

but this is confusing, and we should fix it properly (so that fields have the same name...), also see https://github.com/cctbx/dxtbx/pull/632

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.