DiamondLightSource / DiamondLightSource/mx-bluesky

Do not allow setting complex params

Open
#350 0 comments 0 reactions 0 assignees View on GitHub
hyperion
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

When setting params in pydantic models we don't want to do `fgs_params.experiment_params = x`, instead we want to go through the pydantic conversion. See (https://github.com/DiamondLightSource/python-artemis/commit/aa05a97bd5808641cd424fc27e2897d49eabc2b3). We should make it so that it's not possible to set these things directly, we can probably do this through `properties`.

## Acceptance Criteria
* Doing `fgs_params.experiment_params = x` is not possible but running it through json is possible
* There are tests

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.