DiamondLightSource / DiamondLightSource/mx-bluesky

Hyperion only ever uses the default OAV config

Open
#314 3 comments 0 reactions 1 assignee Claimed by @shihab-dls View on GitHub
good first issue hyperion
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

In dodal oav_parameters.py we define `OAV_CONFIG_FILE_DEFAULTS`, which is used for default arguments to `OAVParameters`. Plans like `grid_detect_then_xray_centre` do take an argument for a dict like `OAV_CONFIG_FILE_DEFAULTS` which is passed on to `OAVParameters`, but __main__.py never passes any OAV parameters to the plan, so we only ever use the defaults live

## Acceptance criteria
- there is a means to specify the OAV params in the request json and it is passed on to the plan if and when needed

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.