DiamondLightSource / DiamondLightSource/mx-bluesky

Think about parameter structure of GridScanParams

Open
#308 0 comments 0 reactions 0 assignees View on GitHub
hyperion
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

As part of https://github.com/DiamondLightSource/hyperion/pull/1014 we had to add a parameter in the parameters for FastGridScan that controlled the behavior of the plan. This was frustrating because the parameters are inside `dodal` as they are very closely mapped to the FGS hardware parameters.

We should rethink the way these parameters and the plan are structured to make avoid this split of responsibilities.

## Acceptance Criteria
* There is an architectural discussion on how to do this nicely
* This is minuted and an action is decided
* The action is implemented or a new issue is spun out

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.