DiamondLightSource / DiamondLightSource/mx-bluesky

2D grid scans shouldn't care about Y steps being odd

Open
#288 0 comments 0 reactions 0 assignees View on GitHub
Needed for VMXm grid scans
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

After https://github.com/DiamondLightSource/hyperion/issues/1118, the `xray_centre_plan` throws an error if it is given an odd number of Y steps. This ensures our 3D grid scans work properly, but the change means that this check also occurs for 2D grid scans when it doesn't need to be.
For example, VMXm use 2D grid scans without using the grid detect plan, so the above change will cause their scans to break.

We need to decide how to refactor the 2D / 3D grid scans. We could think of a 3D scan as 2x 2D grid scans, but the motion script doesn't currently work this way

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.