DiamondLightSource / DiamondLightSource/mx-bluesky

box_size_um is required by GenericGrid even though x + y box dimensions can be specified independently

Open
#1,765 0 comments 0 reactions 0 assignees View on GitHub
Needed for VMXm grid scans
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

Vmxm only run the gridscan and do not use the grid detect, however still have to populate `box_size_um` despite it not being used in gridscans.

We should probably separate out the grid specifications for grid detect and grid scan and not require the unneeded fields to be populated especially if the different axes could potentially be specified differently.

## Acceptance Criteria
- Gridscans don't need to specify box_size_um or alternatively,
- Vmxm gridscans specify only box_size_um and compute x/y dimensions from this

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.