DiamondLightSource / DiamondLightSource/mx-bluesky

Bluesky plan entry points shouldn't use parameter components

Open
#1,463 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

From a discussion between @DominicOram and myself today:

We think it's pointlessly messy to try and construct parameters for each plan entry point from our common components. Instead, each entry point should just define its own base model.

The parameter components can still be used to construct our internal parameters, eg `GridCommon`. These are used by our common experiments, so they really are common parameters.

mx-bluesky should handle conversions between these entry point external parameters and internal parameters. See https://github.com/DiamondLightSource/mx-bluesky/pull/1343 for an example of where this has been done

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.