DiamondLightSource / DiamondLightSource/mx-bluesky

Murko: double meaning of MurkoResult

Open
#1,430 0 comments 0 reactions 0 assignees View on GitHub
murko
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

We use `MurkoResult` dataclass to contain results as they come from Murko as well as result objects as used in the MurkoResultsDevice`. These are in different formats so we should not use the same dataclass for both, even though at runtime it works.

We could also use pydantic to increase validation around serialised data.

## Acceptance Criteria
- Specific criteria that will be used to judge if the issue is fixed

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.