DiamondLightSource / DiamondLightSource/mx-bluesky

Undulator sets completing successfully, gap not changed

Open
#1,334 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

During a weekend run, the undulator was requested to move, the gap was set, but the RBV did not change, and the set did not timeout.

https://graylog.diamond.ac.uk/messages/graylog-daq-mx-hyperion_22/7b57eb42-a0f0-11f0-8f22-6e2c9d89af67

See slack conversation at
https://diamondlightsource.slack.com/archives/C048RD0KFFF/p1759742834238719

Several samples were collected with incorrect undulator gap because the RBV isn't validated.

This was on mx-bluesky 1.5.0 which doesn't have the latest `ophyd-async` with limit validation.

Suspect that undulator was reporting that move was done however DMOV has no logs.

Suggest additional check in the set implementation to read back the RBV and raise exception if outside tolerance.

## Acceptance Criteria
- Specific criteria that will be used to judge if the issue is fixed

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.