DiamondLightSource / DiamondLightSource/mx-bluesky

Refactor tests for i04 grid detect the XRC plan entry

Open
#1,307 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

The tests in `test_i04_grid_detect_then_xray_centre_plan.py` are ugly mainly due to how many repeated patches we are using for each individual test. We should tidy this up by making sure only the essential patches are used for each of the tests, and grouping all the tests which require a patch by using a test class, (eg see `TestFlyscanXrayCentrePlan`)

## Acceptance Criteria
- `test_i04_grid_detect_then_xray_centre_plan.py` doesn't contain tests with repeated patches, and we confirm that only the required patches are used for each test.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.