DiamondLightSource / DiamondLightSource/mx-bluesky

Replace `camera_coordinates_to_xyz_mm` and `_project_xyz_to_xy` with derived axes

Open
#1,105 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4
Forks
5
Avg merge
1d 30m
Merged PRs (30d)
2

Description

Following https://github.com/DiamondLightSource/dodal/pull/1215 we now have a derived axis for the movement of a gonio in an OAV plane. We're currently redoing this same maths in other places in Hyperion, specifically:
* camera_coordinates_to_xyz_mm
* _project_xyz_to_xy

We should instead be able to add a similar derived signal to the smargon and use it in these places.

## Acceptance Criteria
- Logic for calculating OAV coordinates in based on smargon co-ordinates are all done in the device

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.