DiamondLightSource / DiamondLightSource/imaging-workflows

CoR sweep param schema missing darks/flats loader params

Open
#131 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
0
Forks
4
Avg merge
1m
Merged PRs (30d)
25

Description

Currently, this parameter schema is missing the darks/flats loader params: https://github.com/DiamondLightSource/imaging-workflows/blob/eb2fcaa2d01969fec25da4b4ed05d95a00d1ba25/httomo/schemas/cor-sweep-param.json#L102-L163

This means that if the user of the schema (such as tomohub) provides these darks/flats values, validation of the JSON object will fail, effectively causing these httomo loader parameters to not be usable with this workflow template.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.