DiamondLightSource / DiamondLightSource/i19-bluesky

Plans to set the attenuation

Open
#8 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

optics
Dominant language
Python
Stars
1
Forks
0
Avg merge
12h 23m
Merged PRs (30d)
2

Description

Goes with [dodal#1007](https://github.com/DiamondLightSource/dodal/issues/1007).
Once there's an attenuation device, have plans that set the attenuator to the closest possible value to the requested one:
- add all functions with the calculations necessary to determine which wedge/foil on the wheel is needed to obtain requested transmission (an argument can be made for having this device in dodal)
- add plans that trigger the attenuator device

## Acceptance Criteria
- There is a plan in the optics, decotated with check access that can set the attenuation and move the motors

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the optics plans and the attenuator device described in this issue, then read dodal#1007 for the device dependency. Trace how existing plans use check access and motor movement. Done means a decorated optics plan calculates the closest requested attenuation, sets the attenuator, and moves the required motors.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.