DiamondLightSource / DiamondLightSource/httomo

Revisit if halving of `--max-memory` value is appropriate

Open
#707 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

The code comment suggests that the halving is done to account for needing to hold both inputs and outputs of a section in memory: https://github.com/DiamondLightSource/httomo/blob/5dbdde134775ff29101c70e6e80c927a7a28381a/httomo/cli.py#L425-L426

However, the function calculating the backing to the dataset store is accounting for the size of both the input and output chunks. Meaning, is there a need to halve the `--max-memory` value if both inputs and outputs are already being accounted for?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.