DiamondLightSource / DiamondLightSource/httomo

Pascal case instance attribute in `UiLayer`

Open
#589 0 comments 0 reactions 0 assignees View on GitHub
minor
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

There's an instance attribute of `UiLayer` which is pascal case: https://github.com/DiamondLightSource/httomo/blob/c7e399d09f56a238e4c731c5f66857047f7f4752/httomo/ui_layer.py#L48

In python it's convention that instance attributes (among other things) are snake case, and that pascal case is reserved for classes.

Therefore, I think this is better named as `self.pipeline_stage_config`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.