DiamondLightSource / DiamondLightSource/httomo

Unnecessary setting of `parameters["in_file"]` in `UiLayer._setup_loader()`

Open
#546 0 comments 0 reactions 0 assignees View on GitHub
minor
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

In the following code:
- the `parameters["in_file"]` gets set to `self.in_data_file`
- then `in_file` gets set to `parameters["in_file"]`

https://github.com/DiamondLightSource/httomo/blob/74b94c9140945211657617c00b7ff9694455d60d/httomo/ui_layer.py#L115-L118

and in the rest of the function, there's no further use of `parameters["in_file"]`.

It seems like defining the `"in_file"` key in the `parameters` dict isn't doing anything useful, the `parameters` dict is never used to get that key-value pair, so it feels like this is unnecessarily passing around information.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.