DiamondLightSource / DiamondLightSource/httomo

Loader factory function doesn't use `MethodRepository` or `module_path` params

Open
#533 0 comments 0 reactions 0 assignees View on GitHub
loader
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

This is something to be aware of if there's any discussions around where new loaders should be put (if that is ever a thing, to add new loaders to httomo).

Currently, the `make_loader()` function that's used to create instances of `LoaderInterface` implementors takes in
- an implementor of `MethodRepository`
- a module path

which it doesn't actually use: https://github.com/DiamondLightSource/httomo/blob/ebd18a6275886bc6e4901bb4b71f9d1760915ffc/httomo/loaders/__init__.py#L13-L54

Relevant questions are things like:
- would we ever need methods database info to create a loader (an implementor of `LoaderInterface`)
- if we have different loaders, would they all be put into one module in httomo (in which case a module path parameter may not be needed), or would different loaders potentially be split into different modules (in which case a module path parameter may be useful)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.