DiamondLightSource / DiamondLightSource/httomo

Check valid slicing in `preview` in YAML checker if data is given

Open
#406 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

If the input data is given to the YAML checker, then the YAML checker will check a few things in the pipeline YAML file relating to the input data (such as if the given `data_path` value exists in the input data file).

One thing that could be checked but isn't currently, is if the `preview` value (if set) is referencing valid indices within the input data. For example, if the input data has shape `(1801, 2160, 2560)`, but the `preview` value specifies an out-of-bounds start/stop range for `detector_y` like:
```yaml
preview:
detector_y:
start: 2200
stop: 2400
```

this could in principle be checked by the YAML checker.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.