DiamondLightSource / DiamondLightSource/httomo

Sinogram centering method for multiple vertical slices

Open
#379 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

As it was raised by beamlines scientists, we probably need to implement an option of providing a list of vertical slices instead of just a single slice to the centering methods that work on sinograms (currently only Vo Centering). The main reason is to be able to identify that the center of rotation is different for different vertical positions in the sample.

What should be done next to those values is the a matter of the discussion. In Savu the average can be taken or even the three values get interpolated between all points therefore resulting in a vector of CoRs for each vertical slice. The latter is probably not needed and also would lead to more involved modifications of the framework. The former is also questionable. If the values are different then by taking the mean we can end up with the value that won't be correct for all vertical positions.

Here are my suggestions to start with:

- Implement a possibility of providing multiple values for the VoCentering method. Modification of the wrapper
- Printing the result of all found CoR values into the log and provide a warning if they are different
- Taking the average and use that for the reconstruction. Print the result of the average and warn user that the average is taken

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.