DiamondLightSource / DiamondLightSource/httomo

Do something with undocumented `pass` in `GenericMethodWrapper._build_kwargs()`

Open
#375 0 comments 0 reactions 0 assignees View on GitHub
minor
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

A bare `pass` with no explanation isn't great if that condition is ever hit: https://github.com/DiamondLightSource/httomo/blob/3276af4c8445a2e4f37806e30c68ca350a014ee3/httomo/method_wrappers/generic.py#L248-L249

Putting something here instead of a `pass` would be best, but if that can't be done, documenting why there is a `pass` here would be useful for developers' understanding.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.