DiamondLightSource / DiamondLightSource/httomo

Remove any duplication of side output checking between UI layer and YAML checker?

Open
#317 0 comments 0 reactions 0 assignees View on GitHub
minor question
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

Both the UI layer (`ui_layer.py`) and the YAML checker (`yaml_checker.py`) seem to have code mentioning the checking of validity of side output references. For example, the following two functions have very similar names:

UI layer: https://github.com/DiamondLightSource/httomo/blob/ae5610a83a691436e0e7deff3a71c2af3f89568e/httomo/ui_layer.py#L239-L261

YAML checker: https://github.com/DiamondLightSource/httomo/blob/ae5610a83a691436e0e7deff3a71c2af3f89568e/httomo/yaml_checker.py#L248-L264

While it's definitely not a proof that they're doing the same thing, it may be worth checking if there is any duplication across the two files.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.