DiamondLightSource / DiamondLightSource/httomo

Add checks for obvious incorrect data values in optional debug run

Open
#267 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

In attempts to run benchmarks on real data (20GB+) using [this](https://github.com/dkazanc/dls_pipelines/blob/main/pipelines/bench_pipeline_gpu_intense_separate_rescale.yaml) pipeline, instances of the `paganin_filter_tomopy` from httomolibgpu producing `NaN` values have been encountered.

In this particular case, the `NaN` values were not initially detected to have originated from the paganin filter method due to no runtime error occurring. The runtime error encountered in `rescale_to_int` (occurring two sections later than the section the paganin filter was in), and it took some time to work from the runtime error in `rescale_to_int` all the way back to its origin in the paganin filter in the first section.

To mitigate issues like this, it may be useful to have some kind of debug checks being performed at runtime (perhaps enabled by a `--debug` flag in the CLI?) that check things that are obviously wrong with data, such as:
- output of block processing being all zeros
- output of block processing being all `NaN` values
- presence of `NaN` values

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.