DiamondLightSource / DiamondLightSource/httomo

Replace angles length consistency check appropriately

Open
#236 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
10
Forks
5
Avg merge
5d 17h
Merged PRs (30d)
1

Description

This commit 608a0fd removed a consistency check in `DataSetBlock` which was asserting that the number of angles wasn't less than the number of projections. This turned out to not always be true (360 data which has been stitched together will have half the original number of angles, so the number of angles will be less than the number of projections in general for 360 pipelines).

However, it ma be sensible to have some kind of consistency check between the number of angles and the data, given that the angles held in `AuxiliaryData` is modifiable via a setter defined on `DataSetBlock`.

Alternatively, perhaps the angles numpy array could be locked/not writeable by default, to reduce the possibility of the number of angles going out of sync with the number of projections (by limiting the situations in which the angles array is modifiable).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.