DiamondLightSource / DiamondLightSource/gda-ispyb-api

Additional ContainerStatus values for VMXi sample handling

Open
#116 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3
Forks
9
PR merge metrics
No merged PRs in 30d

Description

As part of https://jira.diamond.ac.uk/browse/VMXI-1056, it will be necessary to create additional PlateStatus and consequently `ContainerStatus` values to represent separate travel to the load lock in both directions.

The status values that I would like are:

`IN_TRANSIT_TO_LOADLOCK_FROM_HOTEL`
`IN_TRANSIT_TO_LOADLOCK_FROM_LOCAL_STORAGE`

`IN_TRANSIT_TO_LOADLOCK` can be deprecated - until the new code is stable it would be good to retain it.

Also missing is an existing value already used in GDA `ON_GONIO` which has string value "on_gonio"

If there is any additional logic in the database layer it may have to be updated to account for the new values; I am not aware of any but it may be worth checking.

Contributor guide

Open the contributing guide

Research direction

Search the Java sources for ContainerStatus and PlateStatus, then inspect any database-layer handling of their values. Confirm the two new load-lock statuses and the existing ON_GONIO value, retain IN_TRANSIT_TO_LOADLOCK for compatibility, and verify that all relevant persistence paths accept the new values.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, mariadb
Domain
backend, database
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.