DiamondLightSource / DiamondLightSource/fastcs

Handle disconnects

Open
#310 3 comments 1 reaction 0 assignees View on GitHub
needs design
Dominant language
Python
Stars
6
Forks
8
Avg merge
2d 12h
Merged PRs (30d)
3

Description

The current model is when an AttributeIO update or a scan raises an exception, it stops and does not attempt to reconnect. The process will need to restarted once connection is re-established. This was done to prevent it from creating masses of log output.

What behaviour do we want?

- Just keep sending requests and logging errors
- Add some logic to AttributeIO to only log errors once and keep trying, but more quietly
- Stop the application and let K8s restart until it works
- How do we decide when to stop, when just one update loop stops? When all stop?
- Something else?

Thoughts @coretl, @gilesknap?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.