DiamondLightSource / DiamondLightSource/fastcs
Call transport.serve with create_task instead of gather
Open
- Dominant language
- Python
- Stars
- 6
- Forks
- 8
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 3
Description
With gather [e.g.](https://github.com/DiamondLightSource/FastCS/blob/main/src/fastcs/control_system.py#L102) the transport can block the application from shutting down. With create_task ([e.g.](https://github.com/DiamondLightSource/FastCS/blob/main/src/fastcs/control_system.py#L59)) they can't. Only the interactive shell should block the application so that it shuts down when that is stopped.
Currently pva does block, whereas ca does not so it stops cleanly.
Contributor guide
Assessment
This issue has not been assessed yet.