DiamondLightSource / DiamondLightSource/fastcs

Allow for changing of `Waveform` shape

Open
#123 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
6
Forks
8
Avg merge
2d 12h
Merged PRs (30d)
3

Description

In https://github.com/DiamondLightSource/FastCS/pull/119, we create an `NTArray` for `Waveform` values when using the p4p transport.

We would like to use a standard single dimensional array, e.g `NTScalar("ai")` when a shape of `(n,)` is given, and an `NTArray` when more than one dimension is given.

Once https://github.com/DiamondLightSource/FastCS/issues/111 is completed, we can change the shape on the `Waveform` and the p4p transport should swap between these types.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.