DiamondLightSource / DiamondLightSource/fastcs-catio

we need to verify that revision numbers don't change PDOs

Open
#20 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

While debugging an issue with the EL1502 I came across this:

The new highest revision (1441792 = 0x00160000) of EL1502 has different PDO group names:

Old: "Per-Channel", "Combined"
New: "1Ch. +/- Counter", "2Ch. Counter"

These variations between revisions would not break the XML parsing because its just the group names - not actual PDO names, but it did confuse our YAML when we switched to using the highest revision number for each terminal name.

The reason for switching to the highest was that some of the low numbered simple digital inputs seemed to have no PDO symbols and this does imply there can be differences.

The YAML confusion has been resolved by using the YAML revision number when merging XML and YAML (during a clean-yaml operation). But the question of differing PDO names between revision numbers still remains. I had cluade opus scan the XML for such differences and it reported that there were non (only changes when the name gets a suffix like EL1004-0100) - but I'm a little skeptical of this result.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.