DiamondLightSource / DiamondLightSource/fastcs-bacnet
Make FastCS attribute creation use BACPyPes3 enums
Open
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
The bacnet objects we subscribe to come in 6 types. However, this can be reduced to 2 categories: binary and analog. Currently we sort into these categories using the object type string [here](https://github.com/DiamondLightSource/fastcs-bacnet/blob/main/src/fastcs_bacnet/core/FastCS/bacnet_subcontroller.py#L81-L101). It would be better to sort into these categories using the enums given by BACPyPes3.
Contributor guide
Assessment
This issue has not been assessed yet.