DiamondLightSource / DiamondLightSource/fast_dp

refined beam x and y flipped?

Open
#53 2 comments 0 reactions 1 assignee Claimed by @graeme-winter View on GitHub
Dominant language
Python
Stars
7
Forks
12
PR merge metrics
No merged PRs in 30d

Description

If you look at line 306-309 of `fast_dp.py`:

```
self._refined_beam = (
beam_pixels[1] * float(self._xds_inp["QY"]),
beam_pixels[0] * float(self._xds_inp["QX"]),
)
```

It appears to me that the refined beam is being ordered with Y first and X second. I think this is propagating into the `fast_dp.xml` file where `refinedXBeam` and `refinedYBeam` are swapped with respect to the starting values. SynchWeb (master branch) has been written to accept these swapped beam centres, but the changes that were made to Synchweb in order to display things properly for `fast_dp` means that, at least for me, the other pipeline results (autoPROC, xia2-3d, xia2-dials) indicate a badly misaligned beam_xy in my image headers... which I know they are not.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.