DiamondLightSource / DiamondLightSource/ethercat

string needs to be unpacked

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
34
Forks
13
PR merge metrics
No merged PRs in 30d

Description

https://github.com/dls-controls/ethercat/blob/master/ethercatApp/src/ecAsyn.cpp

The method receive_config_on_connect has debugging messages that attempt to print the configuration received from the scanner.
printf is called on the config_buffer "raw". However the scanner sends the configuration packed and the message includes the length of the following string.
So the output is garbled. Example output from ioc running version 4-3

[Fri Nov 13 18:47:58 2015]getting config
[Fri Nov 13 18:47:58 2015]config-file size:111970
[Fri Nov 13 18:47:58 2015]^D
[Fri Nov 13 18:47:58 2015]***********************\*

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.