DiamondLightSource / DiamondLightSource/dodal
Automatically keep I22 and P38 in sync
- Dominant language
- Python
- Stars
- 5
- Forks
- 13
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 10
Description
As a developer I would like to keep P38, at least from an ophyd point of view, as a close representation of I22. Currently they are treated as different beamlines with some similar components.
## Possible Solution
Could we somehow define different versions of particular devices?
## Acceptance Criteria
- [ ] There should be one module, i22.py, p38.py should be deleted
- [ ] dodal connect i22 should work without errors when the I22 PVs are available
- [ ] dodal connect i22 --profile p38 or BEAMLINE=p38 dodal connect i22 (syntax can differ) should work when the P38 PVs are available
- [ ] There should be no errors in either case, dodal should handle the differences between the beamlines
from https://github.com/DiamondLightSource/dodal/issues/502#issuecomment-2232766949
Contributor guide
Assessment
This issue has not been assessed yet.