DiamondLightSource / DiamondLightSource/dodal

Tidy up MJPG and SnapshotWithGrid structure

Open
#50 2 comments 0 reactions 0 assignees View on GitHub
oav question
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

Currently `SnapshotWithGrid` inherits from `MJPG`, both of these are expected to be used in an OAV device. This is quite clean as one provides the snapshots with the grid and one without. However, because of the way Ophyd v.1 creates devices it means that it's not easy to choose at runtime which should be used without:
* Having the OAV contain both devices
* Having two OAV objects, one with grids and one without

We should decide if there is a better way of doing this (do it in v2?) or which of the two approaches above we prefer

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.