DiamondLightSource / DiamondLightSource/dodal

Fix places we overwrite bluesky verbs

Open
#2,117 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
13
Avg merge
3d 2h
Merged PRs (30d)
10

Description

Following https://github.com/bluesky/ophyd-async/pull/1028 we will get exceptions if we override protected bluesky verbs in our devices. We should update `dodal` so that we do not do this.

To test:
* Clone `main` of `ophyd-async`
* Run the `dodal` unit tests, many will fail

## Acceptance Criteria
* `dodal` unit tests will work against main of `ophyd-async`

Contributor guide

Open the contributing guide

Research direction

Start by cloning main of ophyd-async and running the dodal unit tests to identify failures caused by overwritten protected Bluesky verbs. Trace each failing device implementation and update the affected dodal code so it no longer overwrites those verbs. Done means the dodal unit tests pass against ophyd-async main.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.